[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] AC_PROG_MKDIR_P: don't workaround if not buggy
From: |
Eric Blake |
Subject: |
Re: [PATCH] AC_PROG_MKDIR_P: don't workaround if not buggy |
Date: |
Fri, 21 Dec 2012 09:16:36 -0500 (EST) |
> > * m4/gnulib-common.m4 (AC_PROG_MKDIR_P):
> > Define only for Autoconf versions before 2.62.
> > (AC_C_RESTRICT): Use documented AC_AUTOCONF_VERSION, not
> > undocumented m4_PACKAGE_VERSION, for consistency with the
> > abovementioned change to AC_PROG_MKDIR_P. This should suffice
> > since we're checking for 2.62 or later, and AC_AUTOCONF_VERSION
> > was introduced in 2.62.
> > ---
>
> > +m4_if(m4_version_compare(m4_defn([AC_AUTOCONF_VERSION]),[2.62]),[-1],[
>
> I still need to test to make sure, but I'm thinking this WON'T work
> with 2.59. m4_defn([undefined]) is fatal.
Just confirmed on RHEL 5.8; it IS fatal :(
executing aclocal -I glm4
glm4/gnulib-common.m4:297: error: m4_defn: undefined macro: AC_AUTOCONF_VERSION
glm4/gnulib-common.m4:297: the top level
autom4te: /usr/bin/m4 failed with exit status: 1
aclocal: autom4te failed with exit status: 1
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org