Re: [libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

On 10/31/2013 07:26 AM, Martin Kletzander wrote:

>>> address@hidden:/home/jenkins/workspace/libvirt/platform/freebsd-9/gnulib/tests
>>> # ./test-poll
>>> Unconnected socket test... passed
>>> Connected sockets test... failed (expecting POLLHUP after shutdown)
>>> General socket test with fork... failed (expecting POLLHUP after shutdown)
>>> Pipe test... passed
>>
>> Has that test been failing prior to my submodule update for libvirt?
>> This is likely a latent bug in gnulib that has been manifesting itself
>> on FreeBSD for a much longer time period than just the month's worth of
>> patches I pulled in by updating; but you are right that it would be nice
>> to fix it upstream.
>>
> 
> I thought it did fail earlier, but now I see it didn't.  There was an
> IP addresses misconfiguration, but trying that now, I can only find a
> commit on which there were 2 errors instead of 3, but none which would
> successfully survive 'make check'.
> 
> So sorry for the noise I made about that.

Don't apologize - it's something that upstream gnulib needs to fix
someday, even if the downstream libvirt patch wasn't actually pointing
out a gnulib regression.  But I don't know how many active FreeBSD users
are on the gnulib list to help with the analysis effort, so it may be a
while before fixes appear (at any rate, a failed gnulib test is not
necessarily a reason to hold up a downstream release).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature