[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [V2 PATCH] Implement SM3 hash algorithm in gnulib and the computing
From: |
Jia Zhang |
Subject: |
Re: [V2 PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils. |
Date: |
Sat, 28 Oct 2017 21:22:15 +0800 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
于 2017/10/28 下午9:09, Bruno Haible 写道:
> Jia Zhang wrote:
>>> gcc: error: @LIB_CRYPTO@: No such file or directory
>>
>> Thanks for your comments. I fixed it and the test passes. I just
>> feel strange that test-sm3 was built out without error if I
>> compiled gnulib with coreutils together.
>
> It passed with coreutils because coreutils requests other crypto
> modules as well, and these set LIB_CRYPTO.
>
> The particular thing about Gnulib is that people can use an
> *arbitrary subset* of its set of modules. Therefore, when we add a
> module we must make sure that 1. the module works standalone,
> without any other modules, 2. conflicts with other modules are
> avoided. 'gnulib-tool --create-testdir' is the tool for verifying
> this.
Make sense. Thanks you very much!
Jia
>
> Bruno
>