Re: af_alg: Add ability to use Linux kernel crypto API on data in memory

[Matteo Croce]

On Sun, May 6, 2018 at 9:00 PM, Bruno Haible <address@hidden> wrote:
> Hi Matteo,
>
>> I've checked out latest gnulib, and after double checking that commit
>> 761523ddea70f0456b556c09868910686751fff5 was there I ran this:
>
> Please take commit 55efbb1178e045d52b0f52a2160f3d943c4f8a2c plus the patch
> from https://lists.gnu.org/archive/html/bug-gnulib/2018-05/msg00035.html.
> Then follow these instructions:
>
> $ ./gnulib-tool --create-testdir --dir=testdir --single-configure --symlink 
> crypto/md5 crypto/sha1 crypto/sha256 crypto/sha512
> $ cd testdir
> $ mkdir without; (cd without; ../configure CPPFLAGS=-Wall CFLAGS=-O2 
> --without-linux-crypto; make && make check)
> $ mkdir with; (cd with; ../configure CPPFLAGS=-Wall CFLAGS=-O2 
> --with-linux-crypto; make && make check)
>
> Bruno
>

Hi Bruno,

I have 55efbb1178e045d52b0f52a2160f3d943c4f8a2c but the patch fails to apply.

$ wget -qO- 
https://lists.gnu.org/archive/html/bug-gnulib/2018-05/txtdxlUGSMYnt.txt
|patch -p1
patching file lib/md5.c
Hunk #1 FAILED at 221.
1 out of 1 hunk FAILED -- saving rejects to file lib/md5.c.rej
patching file lib/sha1.c
Hunk #1 FAILED at 209.
1 out of 1 hunk FAILED -- saving rejects to file lib/sha1.c.rej
patching file lib/sha256.c
Hunk #1 FAILED at 273.
Hunk #2 FAILED at 295.
2 out of 2 hunks FAILED -- saving rejects to file lib/sha256.c.rej
patching file lib/sha512.c
Hunk #1 FAILED at 281.
Hunk #2 FAILED at 303.
2 out of 2 hunks FAILED -- saving rejects to file lib/sha512.c.rej

BTW, the instructions are you referring to, are for AES. For SHA1 and
other hashes, an ASM implementation of the algorythm with SSSE3 or
AVX2 is compiled into the kernel.
FYI: 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/x86/crypto/sha1_avx2_x86_64_asm.S

-- 
Matteo Croce
per aspera ad upstream