[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Compilation error in glob.c with gcc 4.8
From: |
Bruno Haible |
Subject: |
Re: Compilation error in glob.c with gcc 4.8 |
Date: |
Sat, 18 Aug 2018 17:26:07 +0200 |
User-agent: |
KMail/5.1.3 (Linux/4.4.0-130-generic; KDE/5.18.0; x86_64; ; ) |
Hi Paul,
> I installed the attached which should fix things, albeit more drastically
> than
> I'd like as it creates glob.h in cases where it's not needed.
This is frustrating in two aspects:
1) Reuben clearly stated a problem that he perceived:
> > Looks like lib/malloc/scratch_buffer.h needs to #include libc-config.h
for
> > libc_hidden_proto?
Indeed, the module description modules/scratch_buffer states that he
should be able to
#include <scratch_buffer.h>
but he can't do so because this header file uses the undefined macro
libc_hidden_proto.
If the module had a unit test, this bug would have been apparent much sooner.
2) Paul Smith requested in
<https://lists.gnu.org/archive/html/bug-gnulib/2018-08/msg00017.html>
that .h files be omitted when they are not necessary. I have started work
in this direction (regarding iconv-h, utime-h, fnmatch-h, glob-h), and
there is more to come.
Now, you revert part of these changes without discussion?!
I thought that on this mailing list, we had an agreement that we discuss
patches _before_ committing them, if they are controversial.
Bruno
- Compilation error in glob.c with gcc 4.8, Reuben Thomas, 2018/08/17
- Re: Compilation error in glob.c with gcc 4.8, Reuben Thomas, 2018/08/17
- Re: Compilation error in glob.c with gcc 4.8, Reuben Thomas, 2018/08/17
- Re: Compilation error in glob.c with gcc 4.8, Reuben Thomas, 2018/08/17
- Re: Compilation error in glob.c with gcc 4.8, Paul Eggert, 2018/08/18
- Re: Compilation error in glob.c with gcc 4.8,
Bruno Haible <=
- Re: Compilation error in glob.c with gcc 4.8, Paul Eggert, 2018/08/18
- Re: Compilation error in glob.c with gcc 4.8, Bruno Haible, 2018/08/18
- Re: Compilation error in glob.c with gcc 4.8, Paul Eggert, 2018/08/18
- Re: Compilation error in glob.c with gcc 4.8, Reuben Thomas, 2018/08/18
- Re: Compilation error in glob.c with gcc 4.8, Bruno Haible, 2018/08/18
- Re: Compilation error in glob.c with gcc 4.8, Reuben Thomas, 2018/08/18
- Re: Compilation error in glob.c with gcc 4.8, Reuben Thomas, 2018/08/18
- Re: Compilation error in glob.c with gcc 4.8, Bruno Haible, 2018/08/18
- Re: Compilation error in glob.c with gcc 4.8, Reuben Thomas, 2018/08/18
- Re: Compilation error in glob.c with gcc 4.8, Bruno Haible, 2018/08/18