[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add a new VCSToChangeLog script

From: Bruno Haible
Subject: Re: [PATCH] Add a new VCSToChangeLog script
Date: Sun, 27 Jan 2019 19:38:28 +0100
User-agent: KMail/5.1.3 (Linux/4.4.0-141-generic; KDE/5.18.0; x86_64; ; )

Hi Siddhesh,

> Build a more general script that parses changes in a VCS and then
> prints it in a ChangeLog format.

Can you please give some more context?
  * Is it a tool meant to operate on the history and produce a (large)
    ChangeLog file, like gitlog-to-changelog?
    Or is it a tool meant to help the developer prepare a git commit
    message and ChangeLog entry, like 'vc-dwim' from Jim Meyering?
  * In the first case, why is it useful for the program to understand
    the syntax of specific files? Can you show an example? And how
    would you combine the machine-generated parts with the human-written
    parts? I mean, an entry without human-written parts, like
      * foo.c (func1, func2, func3): Modified.
      * bar.c (func4, func5, func6): Modified.
    is not particularly useful to look at.

If the goal is that the tool operates with several version control
systems, do you also have an adapter 'vcs_svn.py'?

Also, since this is a significant contribution, do you already have
started copyright assignments to the FSF for your Gnulib contributions?

> +    codecs = ['utf8', 'latin1', 'cp1252']

1. Can you please use the standardized name 'utf-8'? Use of nonstandardized
   charset identifiers causes interoperability problems.
2. Since latin1 is a subset of cp1252, you can omit 'latin1' here.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]