Re: [Bug-gnupod] Re: playcount not updating.

[H. Langos]

On Fri, Feb 29, 2008 at 12:30:53PM +0100, H. Langos wrote:
> Hi Adrian,
> 
> On Fri, Feb 29, 2008 at 10:22:43AM +0100, H. Langos wrote:
> > On Thu, Feb 28, 2008 at 07:47:52PM +0100, Adrian Ulrich wrote:
> > > If you just skip a song, the iPod will mark it as played but won't update 
> > > the
> > > Play-Counts file. GNUpod will never-ever know that you've played a part 
> > > of this file.
> > 
> > where does the ipod store that information? is it in the skip count? if
> > it is i would gladly modify my otgsync to add the played_flag if
> > the otg data contains a non-zero playcount OR a nonzero skip count.
> 
> Looks like it isn't in the skip count.
> 
> I've changed the respective line in otgsync to
> 
>   $el->{file}->{played_flag} = 1 if ($el->{file}->{playcount} > 0 || 
> $el->{file}->{skipcount} > 0);
> 
> but it seems like "$plcref->{skipcount}{int(@keeper)-1};" is zero. no
> matter if you skip quickly or if you listen to the podcast for 10
> seconds ..
> 

I've found a workable solution for me.

I took a look at $plcref and for a given podcast file I found out that
$plcref contains only one field that seems to be different for files
that are marked with a blue dot to a file that doesn't have a blue dot.
That field is bookmark.

I also verified that files that are skipped very quickly (and thus keep
their blue dot on the ipod) also keep a zero bookmark.

so here's my current version of the played_flag check in otgsync.

$el->{file}->{played_flag} = 1 if ($el->{file}->{playcount} > 0 || 
$el->{file}->{skipcount} > 0 || $el->{file}->{bookmark} > 0);

though i guess that 

$el->{file}->{played_flag} = 1 if ($el->{file}->{playcount} > 0 || 
$el->{file}->{bookmark} > 0);

will work just as well.

cheers
-henrik