[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

NSTableView bug?

From: Ludovic Marcotte
Subject: NSTableView bug?
Date: Wed, 17 Oct 2001 12:08:55 -0400 (EDT)


In NSTableView: - (void) setDataSource: (id)anObject

We do:

  ASSIGN (_dataSource, anObject);
  [self tile];
  [self reloadData];

and it should be:

  _dataSource = anObject;
  [self tile];
  [self reloadData];

We should also remove the TEST_RELEASE(_dataSource) in -dealloc.

The docs don't mention that we must retain the _dataSource and it can
cause a leak (it does for all "logical" dealloc "chain" method calls I can
imagine - the _dataSource will always have a retainCount >= 1).


Live as if you were to die tomorrow.
Learn as if you were to live forever.
 - Gandhi

reply via email to

[Prev in Thread] Current Thread [Next in Thread]