bug-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch to common.make for cygwin paths


From: Stephen Brandon
Subject: Re: patch to common.make for cygwin paths
Date: Tue, 06 Nov 2001 15:47:08 +0000

On Tue, 06 Nov 2001 08:38:24 -0700
 Adam Fedor <fedor@doc.com> wrote:
> Stephen Brandon wrote:
>  >
> 
> > I think the warnings are good and I would not want to
> remove
> > them from Windows compilation, where, to be honest,
> it's
> > easier to make the mistakes because it can be harder to
> > ensure that GNUstep.sh has been run before doing
> > compilations etc. It's not as standardised as unix.
> > 
> 
> 
> I get the bogus warning when compiling on Windows and it
> really is 
> annoying/confusing. So it would be nice to fix it. I
> guess at the risk 
> of expanding the code infinitely, we could do:

    So it's not just me!

> ifeq ($(findstring mingw, $(GNUSTEP_TARGET_OS)), mingw)
>   ...windows specific check
> else
>   ...unix specific check
> endif
> 
> (also including cygwin)

Sounds like a good compromise to me. I wish MAKE had better
regex and conditional support.

Cheers,
Stephen



reply via email to

[Prev in Thread] Current Thread [Next in Thread]