bug-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Cursor setting code


From: Willem Rein Oudshoorn
Subject: [PATCH] Cursor setting code
Date: 16 Dec 2001 21:34:05 +0100
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.1

The following patch improves the cursor setting code.  
The new code will set the cursor on all windows simultaneously
instead of one at the time.  This simplifies the code.

Notes on the patch:

* The blank cursor is used to fake an hidden cursor.  
        Question:  It might be better to add this as a predefined cursor
        in the NSCursor class.  However, the blank cursor is an 
        implementation artifect, so maybe it should not be added.
        I have a slight preference for adding it to the NSCursor class.

* It uncovers a few minor other bugs.  
        - Moving (not dragging) a Text field in Gorm leaves the cursor
        as an IBeam cursor.  
        - If the cursor is not the standard cursor and you create a new 
        window (with a shortcut) under the cursor.  The cursor is not
        reset to the standard cursor.  
        
and perhaps some more.


Wim Oudshoorn.


2001-12-16  Willem Rein Oudshoorn  <woudshoo@xs4all.nl>

        * xgps/Source/SharedX/XGGeneric.h: removed currentMouseWindow instance 
variable

        * xgps/Source/SharedX/XGContextEvent.m ([XGContext 
-receivedEvent:type:extra:forMode:]): 
        removed cursor update code in EnterNotify and LeaveNotify.

        * xgps/Headers/gnustep/xgps/XGContextWindow.h: removed unused instance 
variable `cursor'
        and added _initializeCursorForXWindow: declaration.

        * xgps/Source/SharedX/XGDragView.m ([XGDragView -_setCursor]): fixed 
comment
        ([XGDragView -_handleEventDuringDragging:theEvent]): 
GSAppKitDraggingStatus now 
        only updates cursor when targetMask changes.

        * xgps/Source/SharedX/XGContextWindow.m ([XGContext -_blankCursor]): 
new method
        ([XGContext -_initializeCursorForXWindow:win]): new method
        ([XGContext -_DPSsetcursor::]): rewritten
        ([XGContext -DPSwindow::::::]): cursor initialization changed
        ([XGContext -DPShidecursor]): refactored to use _blankCursor


Attachment: xgps-2.diff
Description: cursor-setting-patch


reply via email to

[Prev in Thread] Current Thread [Next in Thread]