Re: [PATCH]: NSDraw functions with system colors

[Alexander Malmberg]

Adam Fedor wrote:
> Following up on Nicolas' Camaelon package, this patch removes the rect
> fill and draws (some functions) with system colors. Both the OpenStep
> and MacOSX docs on this are terse and ambiguous (The usage of the
> functions conflicts with other documentation e.g. NSCell. MacOSX
> suggests that these aren't even used any more in their AppKit).

Well, the documentation does describe fairly clearly what the result is
supposed to look like. I think it depends on whether the intention is
that they should have that specific look (so applications can use them
to get exact expected results), or that they should look just like what
AppKit itself draws (so applications can use them to "fit in").

> In order
> to make these functions more useful, I've changed the functions to use
> system colors where appropriate, etc. I'll commit in a day or so if
> there are no objections.

Regardless of whether -gui is going to use updated versions of these
functions or a new interface that does the Right Thing, I'd suggest
moving the actual implementations to methods in an internal drawing
class. Methods can be overridden in theme bundles, but functions can't.

- Alexander Malmberg