[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch: NSTimeZone

From: Richard Frith-Macdonald
Subject: Re: Patch: NSTimeZone
Date: Wed, 17 Dec 2003 06:57:37 +0000

On 17 Dec 2003, at 01:13, Sheldon Gill wrote:

Cleans up code and adds documentation.
<NSTimeZone_clean.patch><NSTimeZone_clean.patch.changelog>_____________ __________________________________

I had a look at this patch ... unfortunately it seems to change almost every line of the source code, replacing tabs with incorrect numbers of spaces so that indentation is messed up and making it hard to see what has changed in the functioning of the code.

The restructuring of the comment on the mechanisms for specifying the local timezone looks like an improvement to me.
The comments on the filesystem layout look reasonable but ...
1. I think filesystem documentation should reside in *one* place, and the comments in this file should just direct you to it.
2. I'm not sure about suggesting linking to existing posix files

Perhaps you could re-do this with a patch which maintains the existing use of spaces/tabs/indentation?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]