bug-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gui/configure.ac -- wrong inclusion paths


From: Kazunobu Kuriyama
Subject: Re: [PATCH] gui/configure.ac -- wrong inclusion paths
Date: Sat, 28 Feb 2004 14:45:38 +0900
User-agent: Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.4) Gecko/20030624 Netscape/7.1

Adam Fedor wrote:


On Friday, February 27, 2004, at 09:51 PM, Kazunobu Kuriyama wrote:

But the part

@@ -172,9 +172,6 @@
  AC_MSG_ERROR(gnustep-gui will not compile without tiff)
fi

-ADDITIONAL_INCLUDE_DIRS="ADDITIONAL_INCLUDE_DIRS $GRAPHIC_CFLAGS"
-ADDITIONAL_LIB_DIRS="ADDITIONAL_LIB_DIRS $GRAPHIC_LFLAGS"

is not the one I added recently, so I'm not completely sure we can
safely remove these two lines.  IMO, they are redundant for checking
the audiofile stuff, but appear they were put there in order to
enable us to check the png stuff in a more elaborated way in future
when we need such a elaboration (e.g. detection of .a/.so/.h files
installed in non-standard locations).


I didn't remove the lines, I just moved them to the end of configure.ac.

No, you didn't.  My English was misleading. :)

No test should use these to look for a library or include, it's only used for collecting all the include flags that should go in config.make

I see.  Now I don't see any problem with your patch.  I'd appreciate it
if you could commit it soon.

Thanks,
- Kazunobu Kuriyama






reply via email to

[Prev in Thread] Current Thread [Next in Thread]