bug-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Bad style in NSPageLayout.m


From: Chris B. Vetter
Subject: Bad style in NSPageLayout.m
Date: Thu, 4 Mar 2004 11:39:01 -0800

Line 522+ read

  {
    control = [[self contentView] viewWithTag: NSPLScaleField];
    float scale = 100;
    NSNumber *scaleNumber; 
    if ( (scaleNumber = [dict objectForKey:NSPrintScalingFactor]  ) )

Bad style -- not every system has a C99 compiler yet, eg. NetBSD.

Apart from that, it may be handy to declare a variable whereever and
whenever you need it, but it makes code harder to read and understand.

So please, unless you work on your own project, stick variable
declaration at the top of a block once you're done working on it...

-- 
Chris




reply via email to

[Prev in Thread] Current Thread [Next in Thread]