Re: [PATCH] Proposal to fix NSCell issue

[Quentin Mathé]

Le 23 mars 04, à 21:07, Fred Kiefer a écrit :

> Quentin Mathé wrote:
>
> > Le 23 mars 04, à 01:07, Quentin Mathé a écrit :
> >
> > > Well, here is two patches which add -performClickWithFrame:inView: 
> > > to NSCell and mark performClick: as deprecated.
> > > If everybody is ok, I can commit this NSCell modification.
> >
> > Here are a more complete set of patches to fix the related issues :
>
> I like the code in NSCell and also the cleanup of the unneeded 
> defintions for NSButton, what worries me is the sending of the action 
> in NSButtonCell. This already gets done in the super class, so why 
> doublicate it here?

Sorry, it's an error.

> Also I see no reason for the change on NSWindow, performClick: will 
> still work, so why change it?

Yes, it will still work until a next release when we will remove 
-performClick: method from NSCell (Alex has proposed to deprecate 
performClick; and I think it is the right decision). What do you think 
?

>  For NSPopupButtonCell the documentation states that the default 
> action should be the the opening of the popup, so perhaps the whole 
> code here is unneeded we just should set up the action and target 
> correctly for the cell.

Why not…

> And for NSCell the documentation has some hint that the sender will be 
> used if no control view is already set.

May be, but -[NSCell performClick:] is a hack (doesn't follow the 
NSCell philosophy) and it doesn't work well in many case even if we 
take that in account.

--
Quentin Mathé
qmathe@club-internet.fr