[bug #43460] The class NSURLConnection needs to be tested more thoroughly

[Richard Frith-Macdonald]

Follow-up Comment #1, bug #43460 (project gnustep):

I really love this patch and the fact that you have produced testcases (they
worked nicely for me and helped me check your NSURLProtocol patch).

However, I'm afraid I don't think I can put it in the gnustep-base testsuite
as it is.
The reason is that the Helper code depends on libWebServer and libPerformance,
but those libraries may not be available ... they certainly aren't available
when bootstrapping the system, first time you build base and run the
testsuite.

So, I see two possibilities to make it possible to include these tests:
1. add some mechanism to detect whether the libraries are available and only
build/run the testcases if they are, or
2. rewrite so that the WebServer library isn't used (ie implement minimal
server code as done for the NSURLHandle and NSURL helper).

A side issue ... you have comments saying that you load helper code as a
bundle rather than a shared library, because you don't know how to link a
library form the Helpers subdirectory.  I actually don't see a problem with
using a bundle, but if you think a library would be simpler then all you need
to do is use the standard gnustep-make mechanism:
Add a line to your GNUmakefile.preamble saying something like
ADDITIONAL_TOOL_LIBS += -L./Helpers -lTestConnection


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?43460>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/