[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-grep] grep-2.5.1a bug report: broken egrep and fgrep

From: Aharon Robbins
Subject: Re: [bug-grep] grep-2.5.1a bug report: broken egrep and fgrep
Date: Wed, 24 Nov 2004 13:11:24 +0200

> Julian Foad <address@hidden> wrote:
> > Stepan Kasal wrote:
> >> I fixed it now in the CVS.  (Sorry, Julian, that I haven't submitted it
> >> for review; I wanted to say that it had been already fixed...)
> >
> > That's OK.  There is no need to submit a patch for review if you are 
> > confident
> > that it is correct.
> Be careful if you're setting policy.  That is a slippery slope :)
> In my experience, the `obviously correct' change that I opt not to have
> reviewed is generally more likely to be buggy than one for which I've
> exercised due diligence (ChangeLog, test case(s), justification, etc)
> in preparation for peer review.

Come now, we all learned the right order in which to do things:

        build, ship, test.

(:-)  Seriously, Jim's right, I've had that experience too.  Of course,
I don't know that I always remember the lesson... :-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]