bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Use of 0 instead of NULL in src/kwset.c


From: Paul Eggert
Subject: Re: Use of 0 instead of NULL in src/kwset.c
Date: Mon, 04 Jul 2005 00:05:59 -0700
User-agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux)

Charles Levert <address@hidden> writes:

> +       unsigned u = kwset->mind - (i + 1);

A minor point: the usual GNU style is to say "unsigned int" rather
than plain "unsigned".

Another point, still minor (though less minor): Why not just use
"int"?  That will work here; no overflow is possible, since both
values are nonnegative.  In general it's better to stick with the data
types that the rest of the code is using, and in this case it's int.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]