Re: Changes to grep/src/grep.c

[Julian Foad]

Charles Levert wrote:
> Index: grep/src/grep.c
> diff -u grep/src/grep.c:1.105 grep/src/grep.c:1.106
> --- grep/src/grep.c:1.105       Tue Jun 21 14:18:04 2005
> +++ grep/src/grep.c     Tue Jun 21 14:58:50 2005
[...]
> +const char *
> +color_cap_xm_fct(void)
> +{
> +  /* This experimental feature should stay undocumented for now.  */
> +  pseudo_markup = 1;
> +
> +  sgr_start = "<grep:%s>";
> +  sgr_end   = "</grep:%s>";
> +
> +  /* The user can just redefine them to the empty string afterwards.  */
> +  grep_color     = "matched-text";
> +  filename_color = "filename";
> +  line_num_color = "line-number";
> +  byte_num_color = "byte-offset";
> +  sep_color      = "separator";
> +  mlines_color   = "matching-line";
> +  context_color  = "context-line";
> +
> +  return NULL;
> +}

I don't know if you realised what you were including here.  Please could you 
avoid committing experimental code like this to the stable code base.  In fact, 
please commit a change that removes all traces of that "XM" feature.  Sorry if 
that sounds a bit harsh, but we don't want to get into another "Oh, it's been 
like that for two years now, it just needs a bit more work and bug fixing..." 
situation.

- Julian