bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: tests/yesno.sh, kinds of line (matching/non-matching, selected/rejec


From: Charles Levert
Subject: Re: tests/yesno.sh, kinds of line (matching/non-matching, selected/rejected)
Date: Sun, 13 Nov 2005 18:00:52 -0500
User-agent: Mutt/1.4.1i

* On Sunday 2005-11-13 at 21:55:57 +0000, Julian Foad wrote:
> Charles Levert wrote:
> >
> >> sl:  terminfo-like string capability for selected lines
> >> cx:  terminfo-like string capability for context lines
> [...]
> >One consequence to document is that now,
> >both sl and cx must be able to "support" mt.
> 
> Er... because Matched Text is printed within a Context line?  When?

That's the whole -v thing.  With -v, a context
line is a selected line is a matching line with
at least one matching part in it.


> >By this I mean that the code intentionally does
> >
> >   sgr_start(sl or cx)
> >   fwrite(non-matched text)
> >   /* no sgr_end() here */
> >   sgr_start(mt)
> >   fwrite(matched text)
> >   sgr_end()
> >   sgr_start(sl or cx)
> >   fwrite(non-matched text)
> >   sgr_end()
> >   fputs("\n")
> >
> >for matching lines,
> 
> Yes, but not for context lines: for them it just calls print_line_tail().

Not anymore, that is the bug in the code you see
in latest CVS.  It's what going to be fixed.
The new code will have appropriately named
variables and macros that will make things
very clear.

I'll post a patch soon, I just need to extract
those changes from others I made in my personal
copy.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]