[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 16/17] grep: remove check_multibyte_string, fix non-UTF8 miss

From: Paolo Bonzini
Subject: Re: [PATCH 16/17] grep: remove check_multibyte_string, fix non-UTF8 missed match
Date: Mon, 15 Mar 2010 10:06:21 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.3

On 03/14/2010 05:10 PM, Norihiro Tanaka wrote:

When a line matches with kwset and fails in the is_mb_middle test,
bug#23814 is caused by not checking following of the line (Never looks
for the second match for the line.) .

In this case, by matching kwset for following, the bug will be solved.

For a simple pattern which doesn't contain the wild-card and the
repetition expression, I think that dfaexec is unnecessary and only
kwsexec is needed as well as fgrep.

All true however, with enough heavy changes going into grep, I preferred a slightly suboptimal patch for what is after all a very rare case.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]