[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 6/9] dfa: cache MB_CUR_MAX for dfaexec

From: Paolo Bonzini
Subject: Re: [PATCH 6/9] dfa: cache MB_CUR_MAX for dfaexec
Date: Wed, 17 Mar 2010 10:34:59 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.3

+static void
+free_mbdata (struct dfa *d)
+  int i;

Since I and J are always non-negative,
please declare them as "unsigned int".


I realize all of the other "counter-style" (or otherwise guaranteed
to be non-negative) members have type "int", but that is wrong.
They should all use unsigned types.

So please start by making mb_cur_max be "unsigned int".


    /* These stuff are used only if MB_CUR_MAX>  1 or multibyte environments.  

While you're there, you might want to 's/These stuff/The following/'

See the other patch I sent; I pushed both.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]