[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/9] grep: remove one #ifdef

From: Paolo Bonzini
Subject: Re: [PATCH 2/9] grep: remove one #ifdef
Date: Fri, 19 Mar 2010 15:22:02 +0100

On Fri, Mar 19, 2010 at 14:51, Jim Meyering <address@hidden> wrote:
> Paolo Bonzini wrote:
>> * search.c (Ecompile): Always go through GEAcompile.
> This lazy^W time-constrained reviewer doesn't see off-hand why
> you're doing this, or why it's ok.  I presume it's a no-semantic-change.

Yes, this way it goes through the same code path for both grep and
egrep.  For the next patches in the series, it makes sense because
Ecompile becomes a 1-line function I can move to esearch.c, instead of
a stripped-down version of GEAcompile.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]