[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch #7132] Small change to grep-2.6

From: Paolo Bonzini
Subject: Re: [patch #7132] Small change to grep-2.6
Date: Wed, 24 Mar 2010 16:18:45 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.3

I post patches of small change to grep-2.6.


   I seem that It should match at the head of the line when start_ptr
   isn't set.

Do you have a testcase?  I'm hesitant to apply this without one.

   We don't have to convert text to lower-case in MB_CUR_MAX>  1.

Ok, I made a matching change to the XXX comment. However, maybe we have to provide instead a !MBS_SUPPORT version of mbtolower, and use it unconditionally?

   When MBS_SUPPORT isn't defined, MB_CUR_MAX mayn't be defined.


   We treat an invalid sequence or a truncated multibyte character as a
   single byte character, mbstate may need to be reset.

I'm not sure it matters for is_mb_middle, but I applied it anyway.

diff5 is ok too, but I made some changes there.

Would you mind reviewing the patches I posted to the mailing list?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]