[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch #7132] Small change to grep-2.6

From: Norihiro Tanaka
Subject: Re: [patch #7132] Small change to grep-2.6
Date: Thu, 25 Mar 2010 01:21:19 +0900

Hi Paolo,

> > diff1:
> >    I seem that It should match at the head of the line when start_ptr
> >    isn't set.
> Do you have a testcase?  I'm hesitant to apply this without one.

No. Though I had the test case for this patch,  I have lost it...
A little time is necessary to make it.

> > diff2:
> >     We don't have to convert text to lower-case in MB_CUR_MAX>  1.
> Ok, I made a matching change to the XXX comment.  


> However, maybe we have 
> to provide instead a !MBS_SUPPORT version of mbtolower, and use it 
> unconditionally?

Hmm, We mayn't also need to convert a text into the lower case for
MB_CUR_MAX == 1, but I don't make sure that.

> diff5 is ok too, but I made some changes there.
> Would you mind reviewing the patches I posted to the mailing list?

Ok. But I don't like cur_mb_len not to be modified with `const',
though it's always equal to 1 in !MBS_SUPPORT.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]