bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] dfa/grep: fix compilation with MBS_SUPPORT


From: Jim Meyering
Subject: Re: [PATCH v3] dfa/grep: fix compilation with MBS_SUPPORT
Date: Thu, 25 Mar 2010 21:34:01 +0100

Eric Blake wrote:
> On 03/25/2010 06:38 AM, Paolo Bonzini wrote:
>>  static void
>> -setbit_case_fold (wint_t b, charclass c)
>> +setbit_case_fold (
>> +#ifdef MBS_SUPPORT
>> +                  wint_t b,
>> +#else
>> +                  unsigned int b,
>> +#endif
>> +                  charclass c)
>>  {
>
> This looks kind of awkward.  Could we instead do:
>
> #ifdef MBS_SUPPORT
> typedef grep_wint wint_t;
> #else
> typedef grep_wint unsigned int;
> #endif
>
> static void
> setbit_case_fold (grep_wint b, charclass c)
> {

Yes, please ;-)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]