Re: mostly-cleanup/readability/maintainability patches

[Jim Meyering]

Eric Blake wrote:
> On 04/04/2010 01:43 AM, Jim Meyering wrote:
>> +++ b/configure.ac
>> @@ -128,6 +128,12 @@ if test "$gl_gcc_warnings" = yes; then
>>    AC_SUBST([GNULIB_WARN_CFLAGS])
>>  fi
>>
>> +# By default, argmatch should fail calling usage (1).
>> +AC_DEFINE([ARGMATCH_DIE], [usage (1)],
>> +          [Define to the function xargmatch calls on failures.])
>> +AC_DEFINE([ARGMATCH_DIE_DECL], [void usage (int _e)],
>> +          [Define to the declaration of the xargmatch failure function.])
>
> Should that be usage (EXIT_FAILURE), rather than usage (1)?

Yes.  It was fixed shortly thereafter:

  http://git.savannah.gnu.org/cgit/grep.git/commit/?id=f95776680cc4c1

Thanks.