Re: [PATCH] dfa: drop ORTOP

[Jim Meyering]

Paolo Bonzini wrote:
> * src/dfa.c (token, prtok, addtok_mb, nsubtoks, dfaanalyze, dfamust):
> Remove ORTOP.
> (regexp): Remove parameter, always add OR at the end, adjust callers.
> (atom): Adjust caller.
> (dfaparse): Adjust caller.  Always add OR at the end.
> ---
>  src/dfa.c |   23 ++++++-----------------
>  1 files changed, 6 insertions(+), 17 deletions(-)
>
> diff --git a/src/dfa.c b/src/dfa.c
> index 0ff2ee3..6306f30 100644
> --- a/src/dfa.c
> +++ b/src/dfa.c
> @@ -207,9 +207,6 @@ typedef enum
>    OR,                                /* OR is an operator of two arguments 
> that
>                                     matches either of its arguments. */
>
> -  ORTOP,                     /* OR at the toplevel in the parse tree.
> -                                   This is used for a boyer-moore heuristic. 
> */
> -

Good one.
Having a separate symbol for ORTOP was unnecessary,
since it was treated just like "OR".  Saying something
like this in the log would be nice.

I didn't bother to see if it was ever used differently,
as implied by its comment.

ACK.