bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch #6569] Allow grep to work in small stack environment


From: Patrick Boyd
Subject: Re: [patch #6569] Allow grep to work in small stack environment
Date: Wed, 8 Sep 2010 11:15:44 -0500

This change allows a UEFI port of grep to work in the UEFI simulator which
runs on top of Windows or Linux with a pretty small stack.

On Fri, Aug 27, 2010 at 5:04 PM, Jim Meyering <address@hidden> wrote:

> Paul Eggert wrote:
> > On 08/27/2010 01:39 AM, Jim Meyering wrote:
> >
> >>   - use xnmalloc, not malloc+test+return, so we don't ignore malloc
> failure.
> >>   - use sizeof *VAR, not "sizeof TYPE" -- the former is more
> maintainable.
> >>   - adjust indentation to retain declaration alignment
> >
> > There are many places in other GNU apps, including gnulib, where
> > it's assumed that one can declare a 4 kB-or-so array on the stack without
> > any problem.  So I'm surprised to see the need for this change to GNU
> grep.
> > Surely we don't need to go through GNU apps and rejigger things for
> > configurations with 4 kB stacks?  By today's standards, such stacks are
> > ridiculously small.
>
> Patrick,
>
> For our reference, on what system does this change help you?
>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]