bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] grep: add include guards


From: Paolo Bonzini
Subject: Re: [PATCH] grep: add include guards
Date: Sun, 14 Nov 2010 17:24:50 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101027 Fedora/3.1.6-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.6

On 11/14/2010 05:11 PM, Jim Meyering wrote:
Paolo Bonzini wrote:
* src/system.h: Add multiple inclusion guards.
* src/grep.h: Likewise.
...
diff --git a/src/grep.h b/src/grep.h
+#ifndef GREP_GREP_H
+#define GREP_GREP_H 1
...
+#endif
...
diff --git a/src/system.h b/src/system.h
...

Those look fine.  Thanks.
You're adding them just on principle?

Just in principle, I have some patches that actually failed to compile without guards but I'm not submitting them.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]