Re: [PATCH 1/2] tests: make test runner a script, not a shell function

[Jim Meyering]

Stefano Lattarini wrote:

> [Adding bug-grep, dropping bug-coreutils and automake-patches]
>
> Reference:
>   <http://lists.gnu.org/archive/html/bug-coreutils/2011-06/msg00097.html>
>
> On Sunday 19 June 2011, Jim Meyering wrote:
>> Thank you!
>> That patch looks fine modulo two typos.
>> I'm folding in these corrections and have adjusted the
>> grammar in the commit log (included below).
>>
>> diff --git a/tests/shell-or-perl b/tests/shell-or-perl
>> index ff92009..08604eb 100644
>> --- a/tests/shell-or-perl
>> +++ b/tests/shell-or-perl
>> @@ -1,7 +1,7 @@
>>  #! /bin/sh
>>  # Run a test script of the coreutils test scripts, picking up the right
>>  # interpreter (i.e., perl or the shell) and the right flags for it (e.g.,
>> -# perl `-T' flag for perl scripts that must rn in tainted mode).
>> +# perl `-T' flag for perl scripts that must run in tainted mode).
>>  #
>>  # Copyright (C) 2011 Free Software Foundation, Inc.
>>  #
>> @@ -71,7 +71,7 @@ while test $# -gt 0; do
>>    shift
>>  done
>>
>> -unset assing_optarg_to_var var
>> +unset assign_optarg_to_var var
>>
> Thank you Jim for your quick answers, and sorry for the blunders above.
>
> I've noticed that grep uses a definition of TESTS_ENVIRONMENT very similar
> to that of coreutils (the one we've just fixed), so it will break with
> oncoming automake too.  Unfortunately, I don't have an FSF assignment
> for grep, so someone else should fix that issue :-(

Thanks.  It's on my list, along with diffutils, parted, idutils,
gzip and vc-dwim.