[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/34] maint: dfa: convert #if-MBS_SUPPORT (free_mbdata)
From: |
Jim Meyering |
Subject: |
Re: [PATCH 09/34] maint: dfa: convert #if-MBS_SUPPORT (free_mbdata) |
Date: |
Thu, 15 Sep 2011 14:01:08 +0200 |
Paolo Bonzini wrote:
> On 09/15/2011 12:27 PM, Jim Meyering wrote:
>> From: Jim Meyering<address@hidden>
>>
>> * src/dfa.c (free_mbdata): Use regular "if", not #if MBS_SUPPORT.
>> ---
>> src/dfa.c | 47 ++++++++++++++++++++++++-----------------------
>> 1 files changed, 24 insertions(+), 23 deletions(-)
>>
>> diff --git a/src/dfa.c b/src/dfa.c
>> index 30013a2..acd99aa 100644
>> --- a/src/dfa.c
>> +++ b/src/dfa.c
>> @@ -3407,38 +3407,39 @@ dfaexec (struct dfa *d, char const *begin, char *end,
>> }
>> }
>>
>> -#if MBS_SUPPORT
>> static void
>> free_mbdata (struct dfa *d)
>> {
>> - unsigned int i;
>> + if (MBS_SUPPORT)
>> + {
...
>> + }
>> }
>> -#endif
>>
>> /* Initialize the components of a dfa that the other routines don't
>> initialize for themselves. */
>
> Either here or later in the series, this if can be removed.
Good catch. I've removed it there -- and adjusted the log, of course.
- Re: [PATCH 01/34] maint: convert #if-MBS_SUPPORT (kwsinit), (continued)
- [PATCH 02/34] maint: convert #if-MBS_SUPPORT (Fcompile, etc.), Jim Meyering, 2011/09/15
- [PATCH 07/34] maint: dfa: convert #if-MBS_SUPPORT (dfafree), Jim Meyering, 2011/09/15
- [PATCH 09/34] maint: dfa: convert #if-MBS_SUPPORT (free_mbdata), Jim Meyering, 2011/09/15
- [PATCH 06/34] maint: dfa: convert #if-MBS_SUPPORT (parse_bracket_exp, part1), Jim Meyering, 2011/09/15
- [PATCH 10/34] maint: dfa: convert #if-MBS_SUPPORT (dfaexec), Jim Meyering, 2011/09/15
- [PATCH 16/34] maint: dfa: convert #if-MBS_SUPPORT (copytoks), Jim Meyering, 2011/09/15
[PATCH 17/34] maint: dfa: convert #if-MBS_SUPPORT (dfaparse), Jim Meyering, 2011/09/15
[PATCH 14/34] maint: dfa: convert #if-MBS_SUPPORT (parse_bracket_exp), Jim Meyering, 2011/09/15
[PATCH 18/34] maint: dfa: convert #if-MBS_SUPPORT (state_index), Jim Meyering, 2011/09/15
[PATCH 28/34] maint: dfa: avoid in-function "#if MBS_SUPPORT" tests, Jim Meyering, 2011/09/15