bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: grep-2.9.69-f91c on Linux/SPARC


From: Paul Eggert
Subject: Re: grep-2.9.69-f91c on Linux/SPARC
Date: Fri, 11 Nov 2011 14:12:28 -0800
User-agent: Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1

On 11/11/2011 01:37 PM, Jim Meyering wrote:
> +    /* Do not test things that are likely to change in a growing file.  */ \
> +    /* && (s)->st_size == (t)->st_size */ \
> +    /* && (s)->st_mtime == (t)->st_mtime */ \
>      && (s)->st_ctime == (t)->st_ctime)

st_ctime is also likely to change in a growing file,
at least it did in my test case on Fedora 15.

And once we drop st_ctime, the rationale for
same_file_attributes is suspect, as it's quite likely for
all the other attributes to be the same.

The simplest fix is to drop same_file_attributes
and SAME_REGULAR_FILE, and for grepfile to invoke
SAME_INODE rather than SAME_REGULAR_FILE.
This should work fine on POSIXish hosts, and
people running on Microsoftish hosts will just
have to be careful to not have grep output into
its input file.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]