Re: [PATCH] Fix src/utils/tfmtodit/tfmtodit.cpp for GCC-3.5

[Art Haas]

On Fri, Apr 09, 2004 at 11:59:30AM +0200, Werner LEMBERG wrote:
> 
> > This file still makes GCC-3.5 unhappy.  The first 'struct' needs a
> > type, and calling it 'S' will produce an error if the second struct
> > is also type 'S', so I changed the second type to 'S2'.  The file
> > now compiles with GCC-3.5.
> 
> Patch applied, thanks.  BTW, what was the reason to disallow anonymous
> types?  I think this will break *many* old code...
> 

Apparently the compiler is becoming stricter with enforcing C++ rules.
Here's a link to the patch that made the change in GCC:

http://gcc.gnu.org/ml/gcc-patches/2004-03/msg00346.html

It is no coincidence that the patches I sent to make groff compile look
vaguely similar to the testcase changes made in the GCC patch.

You were right that the patch breaks code, as it did when building QT
and parts of KDE. See the following thread for some more info:

http://gcc.gnu.org/ml/gcc/2004-03/msg00475.html

As the patches needed to fix the problem are fairly trivial, and
according to the thread make the code more portable, this compiler
change _may_ be beneficial in the long run. At least groff is happy. :-)

Art Haas

-- 
Man once surrendering his reason, has no remaining guard against absurdities
the most monstrous, and like a ship without rudder, is the sport of every wind.

-Thomas Jefferson to James Smith, 1822