[bug #51608] [PATCH] om.tmac-u: Fix some mistakes, fix one bug

[Peter Schaffter]

Follow-up Comment #2, bug #51608 (project groff):


@@ -221,6 +221,9 @@ end 
.ds PDFHREF.TEXTCOL.DEFAULT 0.0 0.3 0.9 
.nr PDFHREF.VIEW.LEADING.C 3i 
.nr PDFHREF.VIEW.LEADING.T 1i 
+.if !r PDFHREF.VIEW.LEADING \{\ 
+. nr PDFHREF.VIEW.LEADING 0 
+.\} 
.nr PDFHREF.VIEW.LEADING.H \n[PDFHREF.VIEW.LEADING] 
\# 
\# ==================================================================
 
_That seems like it's asking for trouble; if anything ever dereferences the
PDFHREF.VIEW.LEADING or PDHREF.VIEW.LEADING.H registers before redefining
them, and if they do what their names suggest, the resulting text will be "set
solid" with no interline spacing. Won't it?_

PDFHREF.VIEW.LEADING controls the distance from the top of the PDF viewer
window to the baseline of link targets.  It has no effect on the formatting of
the .pdf file itself.  The register is set in pdf.tmac; the default is 5
points (5000u).  There's no need for


.if !r PDFHREF.VIEW.LEADING


There's no need to define the "undefined" macros/registers either since, after
loading pdf.tmac and om.tmac, they are, in fact, defined.  The assumption that
pdf.tmac (Deri's re-write of Keith's pdfmark.tmac) is loaded is correct since
pdf.tmac is loaded from troffrc when groff is called with -Tpdf.

The error "can't transparently output node at top level" may safely be
ignored, which is documented.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?51608>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/