Re: Bug and patch for BSD partition detection

[Jochen Hoenicke]

On Dec 6, Heikki Vatiainen wrote:
> "Jochen Hoenicke" <address@hidden> wrote:
> 
> > I don't know much about BSD slices and don't have any to test them,
> > but it looks that your patch breaks some other things, e.g. the
> > geometry command (are BSD partition still printed?).
> 
> Actually, it was the geometry command that made me to investigate 
> what had changed between 0.5.95 and 0.5.96 grub versions. In my 
> original mail, it shows how grub 0.5.96 only prints 'a' when it 
> should print all the partitions like 0.5.95 does. After the patch, 
> the geometry command started working.

Sorry, I was in the wrong function, it is "find" not "geometry" that
stops working.  The find function only searches partitions, that are
not IS_PC_SLICE_TYPE_BSD.  Also the tab completion of partitions uses
the IS_PC_SLICE_TYPE_BSD() macro, so try something like (hd2,3,a<tab>

> Since IS_PC_SLICE_TYPE_BSD calls IS_PC_SLICE_TYPE_BSD_WITH_FS with
> second argument being 0, I came into conclusion that `type' should
> be masked with 0xff in IS_PC_SLICE_TYPE_BSD because
> IS_PC_SLICE_TYPE_BSD is not interested in filesystem type which is 
> carried in bits > 8 in `type'.

Yes, I can understand your patch.  Actually I started by looking at
your patch, figured out why you needed this and this helped me to
produce my patch very quickly.  Thank you for doing the debugging,
that I never could have done, since I don't have a BSD partition.

  Jochen