problem when constructing devfs paths for Linux (2.4)

[Alex Kremer]

hi,

i'm running linux kernel 2.4.0-test12, but this holds for all 2.4 kernels
that i remember.

when using devfs the correct path to disk partition devices is:

        /dev/ide/host0/bus0/target0/lun0/partN

and not
        
        /dev/ide/host0/bus0/target0/lun0/disc/partN

the bug occurs because strcat was used instead of strcpy in
lib/device.c, line 617:

-------------------------------------------------------------------------
diff -ruN grub-0.5.96.1/ChangeLog grub-0.5.96.1-bad/ChangeLog
--- grub-0.5.96.1/ChangeLog     Tue Dec 19 23:51:46 2000
+++ grub-0.5.96.1-bad/ChangeLog Thu Oct 19 21:44:35 2000
@@ -1,9 +1,3 @@
-2000-12-19  Alex Kremer <address@hidden>
-
-        * lib/device.c (write_to_partition): Linux (2.4) devfs path
-       was not correctly built, because '/part' was appended to
-       '.../disc' instead of replacing '/disc'.
-
 2000-10-17  OKUJI Yoshinori  <address@hidden>
 
        * stage2/builtins.c (setkey_func): Clear the all elements of
diff -ruN grub-0.5.96.1/lib/device.c grub-0.5.96.1-bad/lib/device.c
--- grub-0.5.96.1/lib/device.c  Tue Dec 19 23:38:16 2000
+++ grub-0.5.96.1-bad/lib/device.c      Mon Oct 16 16:41:54 2000
@@ -614,7 +614,7 @@
   if (have_devfs ())
     {
       if (strcmp (dev + strlen(dev) - 5, "/disc") == 0)
-       strcpy (dev + strlen(dev) - 5, "/part");
+       strcat (dev + strlen(dev) - 5, "/part");
     }
   sprintf (dev + strlen(dev), "%d", ((partition >> 16) & 0xFF) + 1);
-----------------------------------------------------------------------


kreso

---

System Group,
School of Computer Science and Engineering
 - Hebrew University of Jerusalem