[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Problems with grub-install in CVS
From: |
Jochen Hoenicke |
Subject: |
Re: Problems with grub-install in CVS |
Date: |
Tue, 2 Jan 2001 12:08:38 +0100 (MET) |
On Dec 29, Matthias Granberry wrote:
> If anyone can help me find out what is causing the error, I'd be
> very grateful. I'm still able to use older grub versions, as well
> as CVS grubs from early december. I'm guessing that the
> grub-install changes from the 9th to the 14th might have something
> to do with it.
No, it is certainly a bug in embed in builtins.c I introduced on the
17th. Attached is a patch which should fix it. Pleas tell if that
works (unfortunately I can't easily check embedding after MBR) and I
will check it into the CVS repository.
Jochen
Technical explanation:
> Running "install --stage2=/boot/grub/stage2 /boot/grub/stage1 d (hd0)
> (hd0)-22528799+19 p (hd0,3)/boot/grub/stage2 /boot/grub/menu.lst"... failed
It shouldn't be "(hd0)-22528799+19" but "(hd0)1+19". part_start has
the wrong value, since we never call open_partition when embedding
after the MBR. This didn't harm before, but now part_start needs to
be 0.
Index: builtins.c
===================================================================
RCS file: /cvs/grub/stage2/builtins.c,v
retrieving revision 1.100
diff -u -r1.100 builtins.c
--- grub/stage2/builtins.c 2000/12/17 19:25:50 1.100
+++ grub/stage2/builtins.c 2001/01/02 11:07:07
@@ -971,6 +971,10 @@
char mbr[SECTOR_SIZE];
char ezbios_check[2*SECTOR_SIZE];
+ /* Open the partition. */
+ if (! open_partition ())
+ return 1;
+
/* No floppy has MBR. */
if (! (current_drive & 0x80))
{
- Re: Problems with grub-install in CVS,
Jochen Hoenicke <=