[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: grub-0.93-win32-iso9660.diff
From: |
Robert Millan |
Subject: |
Re: grub-0.93-win32-iso9660.diff |
Date: |
Thu, 4 Sep 2003 16:24:42 +0000 |
User-agent: |
Mutt/1.5.4i |
On Wed, Sep 03, 2003 at 04:18:25PM +0100, Yoshinori Okuji wrote:
> --- Robert Millan <address@hidden> wrote: >
> > I'm interested in your grub-0.93-win32-iso9660.diff patch and would like
> > to get it integrated in GRUB CVS.
>
> That is not your task: One who decides if a feature should be added is the
> maintainer (at least, ultimately). In this project, it is ok for you to commit
> any patch yourself, but only if it is just a bug fix or it is approved by the
> maintainer (i.e. me).
Excuse me then, I didn't mean to do it without your approvation. Although
it wasn't clear to me wether such approvation was implicit. It is clear to
me now.
> As I have been saying many times, adding a new feature must be a conservative
> process. Otherwise, you will get many bugs and enourmous complaints from the
> users, and you will have difficulty in keeping backward compatibility.
>
> Please follow this rule: do not add any new features unless they are critical,
> until 1.0 is released.
ok.
> Are you sure that the features would not unstabilize the existing features? Is
> the code clean enough? It the code consistent with the existing code? Is there
> any good documentation? Do you believe that the implementation is the best way
> to realize such features?
>
> If you still think the patch should be applied even after reading those
> questions, please send me the changelog and a short documentation about how to
> use the new features. Then, I will judge.
Is there a generic answer for these questions when applied to adding a new
filesystem?
> P.S. I think you now understand why it is important to be a maintainer. :)
A bit better, I think :)
--
Robert Millan
"[..] but the delight and pride of Aule is in the deed of making, and in the
thing made, and neither in possession nor in his own mastery; wherefore he
gives and hoards not, and is free from care, passing ever on to some new work."
-- J.R.R.T, Ainulindale (Silmarillion)
- Re: grub-0.93-win32-iso9660.diff, (continued)
- Re: grub-0.93-win32-iso9660.diff, Yoshinori Okuji, 2003/09/03
- Re: grub-0.93-win32-iso9660.diff, Dr. Tilmann Bubeck, 2003/09/04
- Re: grub-0.93-win32-iso9660.diff, Yoshinori Okuji, 2003/09/04
- Re: grub-0.93-win32-iso9660.diff, Robert Millan, 2003/09/04
- Re: [Bug-grub] Re: grub-0.93-win32-iso9660.diff, Jason Thomas, 2003/09/04
- Re: [Bug-grub] Re: grub-0.93-win32-iso9660.diff, Yoshinori Okuji, 2003/09/05
- Re: [Bug-grub] Re: grub-0.93-win32-iso9660.diff, Robert Millan, 2003/09/08
- Re: [Bug-grub] Re: grub-0.93-win32-iso9660.diff, Timothy Baldwin, 2003/09/12
- Re: [Bug-grub] Re: grub-0.93-win32-iso9660.diff, Yoshinori Okuji, 2003/09/13
Re: grub-0.93-win32-iso9660.diff,
Robert Millan <=