Re: vesa graphics support patch

[Yoshinori Okuji]

 --- Shivram Khandeparker <address@hidden> wrote:
> I unserstand that graphics support wont be included till
> version 1.0. But the todo says that graphics can be done
> before v1.0.

They are different. If my understanding is correct, your patch is for GRUB to
use graphics using VESA. What the TODO says is for a Multiboot OS (booted by
GRUB) to use graphics but not for GRUB itself.

> BTW would this patch be included atleast after 1.0

Probably after modifying your patch somewhat. Because GRUB needs code for VESA
to support Multiboot, I think it would be better to share code between GRUB's
display driver and graphics support for Multiboot. Most of the code can be
shared, such as getting information and changing the mode, theoretically.

If you are interested in graphics support for Multiboot, please investigate how
to add the support in your patch. If not, just keep your code clean so that it
is reusable.

Thanks,
Okuji