[bug #33424] resource leak & redundant cehck in emu/hotdisk.c

[David Volgyes]

URL:
  <http://savannah.gnu.org/bugs/?33424>

                 Summary: resource leak & redundant cehck in emu/hotdisk.c
                 Project: GNU GRUB
            Submitted by: dvolgyes
            Submitted on: Sun 29 May 2011 08:39:31 AM GMT
                Category: None
                Severity: Major
                Priority: 5 - Normal
              Item Group: Software Error
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 
                 Release: Bazaar - trunk
         Reproducibility: Every Time
         Planned Release: None

    _______________________________________________________

Details:

Cppcheck found two bugs in hotdisk.c, both of them are real bugs.

[grub-1.99~rc2/grub-core/kern/emu/hostdisk.c:674]: (error) __linux__ is
already guaranteed to be defined

#ifdef __linux__ 
was in a "#ifdef __linux__" section.

[grub-1.99~rc2/grub-core/kern/emu/hostdisk.c:1773]: (error) Resource leak: fd

fd was not closed before "return".

Patch is submitted.




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sun 29 May 2011 08:39:31 AM GMT  Name: hotdisk.patch  Size: 1kB   By:
dvolgyes

<http://savannah.gnu.org/bugs/download.php?file_id=23463>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?33424>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/