[bug #33427] several cppcheck error

[David Volgyes]

URL:
  <http://savannah.gnu.org/bugs/?33427>

                 Summary: several cppcheck error
                 Project: GNU GRUB
            Submitted by: dvolgyes
            Submitted on: Sun 29 May 2011 09:16:13 AM GMT
                Category: None
                Severity: Major
                Priority: 5 - Normal
              Item Group: Software Error
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 
                 Release: Bazaar - trunk
         Reproducibility: None
         Planned Release: None

    _______________________________________________________

Details:

[grub-1.99~rc2/grub-core/gnulib/regcomp.c:2797]: (error) Uninitialized
variable: symb_table

Probably, symb_table should be initialized always.
A possibly fix is submitted. (regcomp.patch)



[grub-1.99~rc2/util/grub-mkpasswd-pbkdf2.c:273]: (error) Deallocating a
deallocated pointer: f

Several fclose(f) were, but there were bad.
(closing NULL or already closed "f", etc.)
Patch is submitted. (grub-mkpasswd-pbkdf2.patch)

[grub-1.99~rc2/util/grub-setup.c:375]: (error) GRUB_MACHINE_PCBIOS is already
guaranteed to be defined

A patch is submitted. (grub-setup.patch)


[grub-1.99~rc2/util/ieee1275/ofpath.c:300]: (error) Resource leak: fd
fd must be closed. A patch is submitted. (ofpath.patch)

[grub-1.99~rc2/util/ieee1275/ofpath.c:423]: (error) Memory leak: of_path 

of_path should be freed. A patch is submitted. (ofpath.patch)


[grub-1.99~rc2/util/ieee1275/ofpath.c:376]: (error) Memory leak: name_buf

This is unclear. I think it is worth to check it, but I have no patch for
this.

The bugs above were found with cppcheck 1.47.





    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sun 29 May 2011 09:16:13 AM GMT  Name: grub-mkpasswd-pbkdf2.patch  Size:
883B   By: dvolgyes

<http://savannah.gnu.org/bugs/download.php?file_id=23466>
-------------------------------------------------------
Date: Sun 29 May 2011 09:16:13 AM GMT  Name: grub-setup.patch  Size: 616B  
By: dvolgyes

<http://savannah.gnu.org/bugs/download.php?file_id=23467>
-------------------------------------------------------
Date: Sun 29 May 2011 09:16:13 AM GMT  Name: regcomp.patch  Size: 637B   By:
dvolgyes

<http://savannah.gnu.org/bugs/download.php?file_id=23468>
-------------------------------------------------------
Date: Sun 29 May 2011 09:16:13 AM GMT  Name: ofpath.patch  Size: 465B   By:
dvolgyes

<http://savannah.gnu.org/bugs/download.php?file_id=23469>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?33427>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/