[bug #36640] Please make grub-probe support symlinks

[Sebastian Pipping]

Follow-up Comment #4, bug #36640 (project grub):

Vladimir,


thanks for coming up with a patch so quickly!  As you pasted the patch inline,
copy-paste produced a malformed patch ..

  # patch -p 0 < patch
  patching file util/getroot.c
  patch: **** malformed patch at line 4: ptr = ret + sizeof ("/dev/disk") +
rdisk - 1;

.. with whitespace broken and even some '*'s missing.

I believed I was able to restore the patch correctly, see [1] for my result to
be sure.

Fortunately, the patch seems to work well.  I confirm all(?) possible
combinations working:

# for d in /dev/loop7 /dev/GRUB_BOOT_TEST_DISK ; do 
    for m in normal-device.map symlink-device.map 
        both-a-b-device.map both-b-a-device.map '' ; do 
      printf "[%s][%s] -> " "$d" "$m"; 
      ./grub-probe --device-map="$m" --target=drive 
        --device "$d" ; 
    done ; 
  done
[/dev/loop7][normal-device.map] -> (hd0)
[/dev/loop7][symlink-device.map] -> (hd0)
[/dev/loop7][both-a-b-device.map] -> (hd0)
[/dev/loop7][both-b-a-device.map] -> (hd0)
[/dev/loop7][] -> (hostdisk//dev/loop7)
[/dev/GRUB_BOOT_TEST_DISK][normal-device.map] -> (hd0)
[/dev/GRUB_BOOT_TEST_DISK][symlink-device.map] -> (hd0)
[/dev/GRUB_BOOT_TEST_DISK][both-a-b-device.map] -> (hd0)
[/dev/GRUB_BOOT_TEST_DISK][both-b-a-device.map] -> (hd0)
[/dev/GRUB_BOOT_TEST_DISK][] -> (hostdisk//dev/loop7)

Best,



Sebastian


[1] http://hartwork.org/public/grub-issue-36640-restored.patch

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?36640>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/