[bug #42134] loadenv.c – check_blocklists – algorithm for block overlap check is wrong

[РоманПехов]

URL:
  <http://savannah.gnu.org/bugs/?42134>

                 Summary: loadenv.c – check_blocklists –  algorithm for
block overlap check is wrong
                 Project: GNU GRUB
            Submitted by: roman_pekhov
            Submitted on: Чтв 17 Апр 2014 14:17:55
                Category: Configuration
                Severity: Major
                Priority: 5 - Normal
              Item Group: Software Error
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 
                 Release: Git master
         Reproducibility: Every Time
         Planned Release: None

    _______________________________________________________

Details:

The check_blocklists function surely writes "malformed file" error if the
block list contains more than one blocks.

The well-known overlap check algorithm is:

if (s1 < e2  &&  s2 < e1)
  {
    return grub_error (GRUB_ERR_BAD_FS, "malformed file");
  }

Swap (s1 <-> s2, e1 <-> e2) is not needed in this case.




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?42134>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/