[bug #43957] Run commands from grub-mkrescue are not checked

[adrian15]

URL:
  <http://savannah.gnu.org/bugs/?43957>

                 Summary: Run commands from grub-mkrescue are not checked
                 Project: GNU GRUB
            Submitted by: adrian15sgd
            Submitted on: vie 09 ene 2015 00:34:19 GMT
                Category: Terminal
                Severity: Major
                Priority: 5 - Normal
              Item Group: Software Error
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 
                 Release: 2.02~beta1
         Reproducibility: Every Time
         Planned Release: None

    _______________________________________________________

Details:

Introduction
============

The original bug was:

xorriso : FAILURE : Cannot find path '/efi.img' in loaded ISO image
when:
grub-mkrescue --output=/tmp/prueba.iso
is run.

Actual bug
===========

grub-mkrescue runs: mformat, mcopy and xorriso. What makes the error above is
not mformat and mcopy executables being installed.

I'm not sure if they are formally requisites for grub but I would encourage
you not to just run these executables and ignore them failing but failing the
full grub-mkrescue execution and explaining that it was one of the executables
fault.

You can find the blaming lines at: 704, 705 and 870.

E.g.
http://git.savannah.gnu.org/cgit/grub.git/tree/util/grub-mkrescue.c?id=bac5d1a64ab4191058a8fd4c05f6b3b339e249e7#n704


grub_util_exec ((const char * []) { "mformat", "-C", "-f", "2880", "-L", "16",
"-i",
            efiimgfat, "::", NULL });

Requisites
==========

Make sure mformat and mcopy are not executables in your path. Either by
removing or by renaming them.

(In Debian) make sure you install grub efi binary packages
(grub-efi-amd64-bin) so that an EFI image is built.

How to test
============

# grub-mkrescue --output=/tmp/prueba.iso

What happens
============
xorriso : FAILURE : Cannot find path '/efi.img' in loaded ISO image

What should have happened
=========================
High level) ISO file is build Ok.
Low level) grub-mkrescue complains when mformat or mcopy executions give an
error.

Other improvements
==================
1) grub-mkrescue should also complain if xorriso execution cannot be
performed. 

2) Check if mformat and mcopy executables are documented as requisites. If
they are not please document them.




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?43957>

_______________________________________________
  Mensaje enviado vía/por Savannah
  http://savannah.gnu.org/