[bug #52236] update-grub processing of lilo.conf append line contains a space at the end

[Matthew Melton]

URL:
  <http://savannah.gnu.org/bugs/?52236>

                 Summary: update-grub processing of lilo.conf  append line
contains a space at the end
                 Project: GNU GRUB
            Submitted by: hairy_marmite
            Submitted on: Mon 16 Oct 2017 02:44:55 PM UTC
                Category: Configuration
                Severity: Major
                Priority: 5 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: Matt Melton
        Originator Email: address@hidden
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 
                 Release: 2.02
         Reproducibility: None
         Planned Release: None

    _______________________________________________________

Details:

This tripped me up during an update (on ubuntu 17.04  grub2/zesty-updates
2.02~beta3-4ubuntu2.2 amd64). 

My lilo.conf on another disk caused the upgrade-grub part of the upgrade to
fail.
After some quick research documented here:
https://answers.launchpad.net/ubuntu/+question/658067
I found the reason, the following part of my lilo.conf:


image = /boot/vmlinuz
  append="root=PARTUUID=345215fe-01" 
  label = Linux
  read-only

Contains a space after the last quote in the append line. 
Lilo itself does not worry about this and boots properly. 
The dequote function in the bash script
"/usr/lib/linux-boot-probes/mounted/50lilo" that parses the lilo.conf file
only removes the second quote on the append line if it is the last character
on the line.

So essentially a non-critical syntax error in lilo.conf, 
caused the update of grub to fail (this was during a kernel security
upgrade).

If you need any further details, let me know and I'll do my best to provide
them. 

Possible fix would be to trim any extra spaces at the end of the line before
(or during ) the call to dequote. 

All the best

M





  




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52236>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/