Re: [Bug-gsl] GSL: make check fails

[Gregery Barton]

I'm compiling with C++ builder for windows, it's definitely a compiler issue.  
I've got GSL checks fulling working now, the other issue was sys/test.c.

The code:

volatile double x = GSL_DBL_MIN;
...
while ((x /= 2.0) > 0)
...

Changed to


while ((x /= 2.0), x > 0)

I'm guessing the result of /= is an rvalue, and an rvalue isn't volatile.  Not 
sure if any version of gcc has the same problem. Before fixing the inline 
problem, adding printf made the bug disappear, and not just near the test code, 
I could add a printf anywhere including the first statement in main() to print 
"hello" and it would cause it to disappear.

Regards,
Greg.



----- Original Message ----
From: Brian Gough <address@hidden>
To: Gregery Barton <address@hidden>
Cc: address@hidden; address@hidden
Sent: Wednesday, 19 August, 2009 6:33:15 PM
Subject: Re: [Bug-gsl] GSL: make check fails

At Tue, 18 Aug 2009 19:19:07 -0700 (PDT),
Gregery Barton wrote:
> Name conflicts like this are resolved by dropping one function.  So
> trace through the code and check that the right downheap() function
> (they have slightly different prototypes) is being called.
> 
> I found this out because of weird failures in statistics and sort as
> well.  And fixed it by removing the "inline" keyword in front of the
> downheap functions.

Interesting.  Were you using the same version of compiler or is this a
general problem?  The functions are all declared static so they should
be accessible only in the original file.

-- 
Brian Gough



      
__________________________________________________________________________________
Find local businesses and services in your area with Yahoo!7 Local.
Get started: http://local.yahoo.com.au