bug-guile
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

1.8.0: The ?: operator used in an lvalue context


From: Mike Gran
Subject: 1.8.0: The ?: operator used in an lvalue context
Date: Thu, 6 Jul 2006 17:49:06 -0700 (PDT)

In guile-core-1.8-20060705, in libguile/environments.c in
core_environments_unobserve(), the question mark/colon operator is
being used without being an rvalue.  Also the value to the left of the
colon appears to be void and the value to the right appears to be a
pointer.

This gets flagged as an error by the AIX xlc compiler.  It might be
cleaner to change it into an if/else.

*** environments.c      2006-07-06 17:00:06.000000000 -0700
--- environments.c.0    2006-07-06 16:57:12.000000000 -0700
*************** 
*** 687,696 ****
          if (scm_is_eq (first, observer))
            {
              /* Remove the first observer */
!           if (handling_weaks)
!                   SCM_SET_CORE_ENVIRONMENT_WEAK_OBSERVERS (env, rest)
!           else
!                   SCM_SET_CORE_ENVIRONMENT_OBSERVERS (env, rest);
              return;
            }
  
--- 687,695 ----
          if (scm_is_eq (first, observer))
            {
              /* Remove the first observer */
!             handling_weaks
!               ? SCM_SET_CORE_ENVIRONMENT_WEAK_OBSERVERS (env, rest)
!               : SCM_SET_CORE_ENVIRONMENT_OBSERVERS (env, rest);
              return;
            }


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]