Re: sleep 999 after tests

[Kevin Ryde]

[belated followup]

Marijn Schouten <address@hidden> writes:
>
> the two sleep 999's in test-suite/tests/popen.test are really annoying. Is
> there any good reason for them to be there?

Yep.  The parent process is supposed to see eof from the child, and in
normal operation it then continues.  If it blocks for the whole sleep
999 then something has gone wrong.

> -                     "exec 1>/dev/null; echo closed 1>&2; exec 2>/dev/null;
> sleep 999")))))
> +                     "exec 1>/dev/null; echo closed 1>&2; exec 2>/dev/null;
> sleep 1")))))

Alas, no, 1 second may not be long enough for the parent to notice what
the child has done, depending on system load etc.

(It may be possible to make a better test, but bear in mind there was an
actual bug in that area in the past, which the tests are trying to
ensure doesn't raise its ugly head again.)