bug#21354: "make check" failure in 0.8.3

[Ludovic Courtès]

Hi,

I see you were running the test suite as ‘root’.  It’s usually not
considered a good idea, but here this has allowed us to find a bug, so
thanks.  :-)

Eric Hanchrow <address@hidden> skribis:

> %%%% Starting test store  (Writing full log to "store.log")
>
> ;;; 
> ("/usr/local/src/guix-0.8.3/test-tmp/var/log/guix/drvs/ga/y376758c2j5c8ia6aw1aar0j57snnn-the-thing.drv.bz2")
>
> ;;; 
> ("/usr/local/src/guix-0.8.3/test-tmp/var/log/guix/drvs/4f/4iprr205w93hihpx2cqs2bz9phaq91-the-thing.drv.bz2")
>
> ;;; (spi (#<<substitutable> path: 
> "/usr/local/src/guix-0.8.3/test-tmp/store/7fnh7srm99a45vlvask08w35hbginm0f-guile-bootstrap-2.0"
>  deriver: 
> "/usr/local/src/guix-0.8.3/test-tmp/store/j3fnxhyy2sz7vb2qq7yq06zc1597faix-guile-bootstrap-2.0.drv"
>  refs: () dl-size: 0 nar-size: 1234>))
>
> ;;; (corrupt #<condition &nix-protocol-error [message: "some substitutes for 
> the outputs of derivation 
> `/usr/local/src/guix-0.8.3/test-tmp/store/7v37cm5jy9y3l9j4apn68389r530jnd6-corrupt-substitute.drv'
>  failed (usually happens due to networking issues); try `--fallback' to build 
> derivation from source " status: 1] 3471840>)
> tests/store.scm:595: FAIL import corrupt path

This is due to a regression in 322eeb87, whereby ‘root’ would be allowed
to import unsigned or corrupt paths (via ‘guix archive --import’.)

Commit ef80ca9 fixes that regression.

> FAIL: tests/syscalls
> ====================
>
> warning: daemon is running as root, so using `--build-users-group' is highly 
> recommended
> %%%% Starting test syscalls  (Writing full log to "syscalls.log")
> %%%% Starting test syscalls  (Writing full log to "syscalls.log")
> %%%% Starting test syscalls  (Writing full log to "syscalls.log")
> %%%% Starting test syscalls  (Writing full log to "syscalls.log")
> %%%% Starting test syscalls  (Writing full log to "syscalls.log")
> tests/syscalls.scm:200: FAIL set-network-interface-address

Fixed in commit 54e515e (this test must be skipped when run as root.)

> FAIL: tests/guix-gc
> ===================
>

[...]

> In guix/store.scm:
>  812: 2 [run-gc #<build-daemon 256.14 2747c80> 1 () 18446744073709551615]
> In srfi/srfi-1.scm:
>  534: 1 [unfold #<procedure 27e24a0 at guix/serialization.scm:162:12 
> (t-7727)> ...]
> In unknown file:
>    ?: 0 [utf8->string #vu8(47 117 115 114 47 108 111 99 97 108 47 115 114 99 
> 47 103 117 105 120 45 48 46 56 46 51 47 116 101 115 116 45 116 109 112 47 115 
> 116 111 114 101 47 114 57 57 52 52 97 54 104 121 102 48 97 98 121 51 119 49 
> 119 98 57 99 106 98 148 106 107 99 53 52 48 115 103 45 116 101 120 116)]
>
> ERROR: In procedure utf8->string:
> ERROR: Throw to key `decoding-error' with args `("scm_from_stringn" "input 
> locale conversion error" 84 #vu8(47 117 115 114 47 108 111 99 97 108 47 115 
> 114 99 47 103 117 105 120 45 48 46 56 46 51 47 116 101 115 116 45 116 109 112 
> 47 115 116 111 114 101 47 114 57 57 52 52 97 54 104 121 102 48 97 98 121 51 
> 119 49 119 98 57 99 106 98 148 106 107 99 53 52 48 115 103 45 116 101 120 
> 116))'.
> unexpected Nix daemon error: reading from file: Connection reset by peer
> + rm -f guix-gc-root
> FAIL tests/guix-gc.sh (exit status: 1)

I think this one was caused by the first bug above: We imported a
corrupt item in the store, so that item has a file name that is not
valid UTF-8, hence this conversion failure.

Could you apply the given patches (you can take them from
<http://git.savannah.gnu.org/cgit/guix.git/log/>, and then apply them
with ‘patch -p1 < patch’ from the top-level source directory), and then
run:

  rm -rf test-tmp && make check

and report the result?

Thank you!

Ludo’.